-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert functional test kits to Kotlin #1087
Open
Goooler
wants to merge
18
commits into
main
Choose a base branch
from
g/20241204/convert-test-kits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/20241204/convert-test-kits
branch
4 times, most recently
from
December 9, 2024 10:48
f70615b
to
b9a8c2d
Compare
Goooler
force-pushed
the
g/20241204/convert-test-kits
branch
3 times, most recently
from
December 10, 2024 08:28
5550deb
to
af07f46
Compare
Goooler
force-pushed
the
g/20241204/convert-test-kits
branch
9 times, most recently
from
December 17, 2024 03:34
0755162
to
18c00e6
Compare
Goooler
commented
Dec 17, 2024
src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ApplicationSpec.groovy
Outdated
Show resolved
Hide resolved
src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/FilteringSpec.groovy
Outdated
Show resolved
Hide resolved
src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/RelocationSpec.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (19)
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ApplicationSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/BasePluginSpecification.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigurationCacheSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/FilteringSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/PublishingSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/RelocationSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/caching/AbstractCachingSpec.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/AbstractMavenModule.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileModule.groovy: Language not supported
- src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileRepository.groovy: Language not supported
- src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableJar.kt: Language not supported
- src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.kt: Language not supported
- src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.kt: Language not supported
- src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/repo/AbstractModule.kt: Language not supported
Goooler
force-pushed
the
g/20241204/convert-test-kits
branch
2 times, most recently
from
December 20, 2024 01:21
f33f355
to
c6006a8
Compare
Goooler
force-pushed
the
g/20241204/convert-test-kits
branch
from
December 21, 2024 09:05
4b96aa2
to
d44592b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed from #1082.